perf(ios): no need to cancel gesture if gesture exists

Tencent · Aug 28, 2023 · 6f2893f · 6f2893f
1 parent 1303783
commit 6f2893f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/renderer/native/ios/renderer/NativeRenderImpl.mm b/renderer/native/ios/renderer/NativeRenderImpl.mm
@@ -759,6 +759,7 @@ - (void)createRenderNodes:(std::vector<std::shared_ptr<DomNode>> &&)nodes
             NativeRenderObjectView *subRenderObject = [self->_renderObjectRegistry componentForTag:@(subviewTags[index]) onRootTag:rootNodeTag];
             [superRenderObject insertNativeRenderSubview:subRenderObject atIndex:subviewIndices[index]];
         }
+        [superRenderObject didUpdateNativeRenderSubviews];
     }];
     for (const std::shared_ptr<DomNode> &node : nodes) {
         NSNumber *componentTag = @(node->GetId());
@@ -780,7 +781,9 @@ - (void)createRenderNodes:(std::vector<std::shared_ptr<DomNode>> &&)nodes
                 UIView *superView = viewRegistry[@(tag)];
                 for (NSUInteger index = 0; index < subViewTags_.size(); index++) {
                     UIView *subview = viewRegistry[@(subViewTags_[index])];
-                    [superView insertNativeRenderSubview:subview atIndex:subViewIndices_[index]];
+                    if (subview) {
+                        [superView insertNativeRenderSubview:subview atIndex:subViewIndices_[index]];
+                    }
                 }
                 [superView clearSortedSubviews];
                 [superView didUpdateNativeRenderSubviews];

diff --git a/renderer/native/ios/renderer/component/view/NativeRenderTouchesView.m b/renderer/native/ios/renderer/component/view/NativeRenderTouchesView.m
@@ -121,11 +121,13 @@ - (void)removeViewEvent:(NativeRenderViewEventType)touchEvent {
     if (NativeRenderViewEventTypeClick == touchEvent) {
         if (_tapGestureRecognizer) {
             [self removeGestureRecognizer:_tapGestureRecognizer];
+            _tapGestureRecognizer = nil;
         }
     }
     else if (NativeRenderViewEventTypeLongClick == touchEvent) {
         if (_longGestureRecognizer) {
             [self removeGestureRecognizer:_longGestureRecognizer];
+            _longGestureRecognizer = nil;
         }
     }
     else if (NativeRenderViewEventTypePressIn == touchEvent) {
@@ -198,7 +200,7 @@ - (void)setTouchEventListener:(OnTouchEventHandler)eventListener forEvent:(Nativ
 
 - (void)addClickEventListener:(OnTouchEventHandler)eventListener {
     if (_tapGestureRecognizer) {
-        [self removeGestureRecognizer:_tapGestureRecognizer];
+        return;
     }
     _tapGestureRecognizer = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(handleClickEvent)];
     _tapGestureRecognizer.cancelsTouchesInView = NO;
@@ -209,7 +211,7 @@ - (void)addClickEventListener:(OnTouchEventHandler)eventListener {
 
 - (void)addLongClickEventListener:(OnTouchEventHandler)eventListener {
     if (_longGestureRecognizer) {
-        [self removeGestureRecognizer:_longGestureRecognizer];
+        return;
     }
     _longGestureRecognizer = [[UILongPressGestureRecognizer alloc] initWithTarget:self action:@selector(handleLongClickEvent)];
     _longGestureRecognizer.cancelsTouchesInView = NO;
@@ -218,6 +220,9 @@ - (void)addLongClickEventListener:(OnTouchEventHandler)eventListener {
 }
 
 - (void)addPressInEventListener:(OnTouchEventHandler)eventListener {
+    if (_pressInEventEnabled) {
+        return;
+    }
     if (_pressInTimer) {
         [_pressInTimer invalidate];
     }