fix(core): remove batch call redundant param

Tencent · Apr 17, 2022 · 784ea7c · 784ea7c
1 parent ab426a6
commit 784ea7c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/core/js/bridge/android/native2js.js b/core/js/bridge/android/native2js.js
@@ -93,10 +93,9 @@ global.hippyBridge = (_action, _callObj) => {
     }
     case 'destroyInstance': {
       global.Hippy.emit('destroyInstance', callObj);
-      const renderId = Date.now().toString();
-      Hippy.bridge.callNative('UIManagerModule', 'startBatch', renderId);
+      Hippy.bridge.callNative('UIManagerModule', 'startBatch');
       Hippy.bridge.callNative('UIManagerModule', 'deleteNode', callObj, [{ id: callObj }]);
-      Hippy.bridge.callNative('UIManagerModule', 'endBatch', renderId);
+      Hippy.bridge.callNative('UIManagerModule', 'endBatch');
       delete __GLOBAL__.nodeIdCache[callObj];
       delete __GLOBAL__.nodeTreeCache[callObj];
       __GLOBAL__.destroyInstanceList[callObj] = true;

diff --git a/core/js/bridge/ios/native2js.js b/core/js/bridge/ios/native2js.js
@@ -71,10 +71,9 @@ __fbBatchedBridge.callFunctionReturnFlushedQueue = (module, method, args) => {
       }
     } else if (method === 'unmountApplicationComponentAtRootTag') {
       global.Hippy.emit('destroyInstance', args[0]);
-      const renderId = Date.now().toString();
-      Hippy.bridge.callNative('UIManagerModule', 'startBatch', renderId);
+      Hippy.bridge.callNative('UIManagerModule', 'startBatch');
       Hippy.bridge.callNative('UIManagerModule', 'removeRootView', args[0]);
-      Hippy.bridge.callNative('UIManagerModule', 'endBatch', renderId);
+      Hippy.bridge.callNative('UIManagerModule', 'endBatch');
       delete __GLOBAL__.nodeIdCache[args[0]];
       delete __GLOBAL__.nodeTreeCache[args[0]];
       delete __GLOBAL__.nodeParamCache[args[0]];

diff --git a/core/src/napi/jsc/native_source_code_ios.cc b/core/src/napi/jsc/native_source_code_ios.cc