feat(react,vue): add position absolute for modal default style

Tencent · Apr 27, 2022 · 7bbed56 · 7bbed56
1 parent 484d6c6
commit 7bbed56
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 15 deletions.
diff --git a/examples/android-demo/res/vendor.android.js b/examples/android-demo/res/vendor.android.js
diff --git a/examples/hippy-vue-demo/src/components/native-demos/demo-dialog.vue b/examples/hippy-vue-demo/src/components/native-demos/demo-dialog.vue
@@ -12,7 +12,6 @@
       v-if="dialogIsVisible"
       animationType="slide"
       :transparent="true"
-      class="dialog-demo"
       :supportedOrientations="supportedOrientations"
       @show="onShow"
       @requestClose="onClose"
@@ -153,22 +152,12 @@ export default {
   text-align: center;
 }
 
-.dialog-demo {
-  position: absolute;
-}
-
 .dialog-demo-wrapper {
   background-color: #40b88377;
-  position: absolute;
-  top: 0;
-  left: 0;
 }
 
 .dialog-2-demo-wrapper {
   background-color: #444444ee;
-  position: absolute;
-  top: 0;
-  left: 0;
   justify-content: center;
   align-items: center;
 }

diff --git a/examples/ios-demo/res/vendor.ios.js b/examples/ios-demo/res/vendor.ios.js
diff --git a/packages/hippy-react/src/components/modal.tsx b/packages/hippy-react/src/components/modal.tsx
@@ -117,6 +117,7 @@ interface ModalProps {
 const styles = StyleSheet.create({
   modal: {
     position: 'absolute',
+    collapsable: false,
   },
   container: {
     position: 'absolute',

diff --git a/packages/hippy-vue-native-components/src/dialog.js b/packages/hippy-vue-native-components/src/dialog.js
@@ -25,6 +25,10 @@ function registerDialog(Vue) {
       defaultNativeProps: {
         transparent: true,
         immersionStatusBar: true,
+        collapsable: false,
+      },
+      defaultNativeStyle: {
+        position: 'absolute',
       },
     },
   });