fix(ios): a rare multithreaded race crash when getting imageProviders

only when user use a custom HippyImageViewCustomLoader and do completion callback in subthread
Tencent · Feb 28, 2024 · c04affe · c04affe
1 parent b0fed38
commit c04affe
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/ios/sdk/base/HippyBridge.mm b/ios/sdk/base/HippyBridge.mm
@@ -245,14 +245,16 @@ - (HippyNextAnimationModule *)animationModule {
 }
 
 - (NSSet<Class<HippyImageProviderProtocol>> *)imageProviders {
-    if (!_imageProviders) {
-        NSMutableSet *set = [NSMutableSet setWithCapacity:8];
-        for (Class moduleClass in self.moduleClasses) {
-            if ([moduleClass conformsToProtocol:@protocol(HippyImageProviderProtocol)]) {
-                [set addObject:moduleClass];
+    @synchronized (self) {
+        if (!_imageProviders) {
+            NSMutableSet *set = [NSMutableSet set];
+            for (Class moduleClass in self.moduleClasses) {
+                if ([moduleClass conformsToProtocol:@protocol(HippyImageProviderProtocol)]) {
+                    [set addObject:moduleClass];
+                }
             }
+            _imageProviders = [NSSet setWithSet:set];
         }
-        _imageProviders = [NSSet setWithSet:set];
     }
     return _imageProviders;
 }