fix(vue): remove redundant props & perf cache logic

Tencent · May 25, 2023 · d635977 · d635977
1 parent 42d4357
commit d635977
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 40 deletions.
diff --git a/examples/hippy-vue-next-demo/src/main-native.ts b/examples/hippy-vue-next-demo/src/main-native.ts
@@ -93,43 +93,6 @@ const initCallback = ({ superProps, rootViewId }) => {
   //   // mount app
   //   app.mount('#root');
   // });
-
-  // invoke custom native apis with type hints
-  Native.callNative('customModule', 'customMethod', '123', 456);
-  Native.callNativeWithPromise(
-    'customModule',
-    'customMethodWithPromise',
-    '123',
-    456,
-  ).then((result) => {
-    console.log(result);
-  });
-
-  // register custom component with type inference
-  registerElement('customComponent', {
-    component: {
-      name: 'custom-component',
-      processEventData(
-        evtData: EventsUnionType,
-        nativeEventParams: { [key: string]: NeedToTyped },
-      ) {
-        const { handler: event, __evt: nativeEventName } = evtData;
-
-        switch (nativeEventName) {
-          // this can infer event is HippyTouchEvent from type narrowing
-          case 'onTest':
-            event.contentOffset = nativeEventParams.position;
-            break;
-          // extended HippyEvent which has testProp
-          case 'onAnotherTest':
-            event.testProp = 123;
-            break;
-          default:
-        }
-        return event;
-      },
-    },
-  });
 };
 
 // start hippy app

diff --git a/packages/hippy-vue-next/src/native-component/animation.ts b/packages/hippy-vue-next/src/native-component/animation.ts
@@ -344,7 +344,6 @@ export function registerAnimation(vueApp: App): void {
           useAnimation: true,
           style: this.style,
           tag: this.$props.tag,
-          playing: this.$props.playing,
           ...this.$props.props,
         },
         this.$slots.default ? this.$slots.default() : null,

diff --git a/packages/hippy-vue-next/src/native-component/swiper.ts b/packages/hippy-vue-next/src/native-component/swiper.ts
@@ -124,7 +124,6 @@ export function registerSwiper(vueApp: App): void {
           ...on,
           ref: 'swiper',
           initialPage: this.$initialSlide,
-          ...this.$props,
         },
         this.$slots.default ? this.$slots.default() : null,
       );

diff --git a/packages/hippy-vue-next/src/runtime/node/hippy-node.ts b/packages/hippy-vue-next/src/runtime/node/hippy-node.ts
@@ -431,7 +431,7 @@ export class HippyNode extends HippyEventTarget {
 
       // if the root node is not rendered on the screen, start rendering from the root node first
       // render the child node if the child node is not rendered
-      renderInsertChildNativeNode(parentNode.convertToNativeNodes(true));
+      const nodeList = parentNode.convertToNativeNodes(true);
       // update the isMounted flag
       parentNode.eachNode((rawNode: HippyNode) => {
         const node = rawNode;
@@ -441,6 +441,7 @@ export class HippyNode extends HippyEventTarget {
         // cache the nodes inserted into the native to improve the search speed
         preCacheNode(node, node.nodeId);
       });
+      renderInsertChildNativeNode(nodeList);
     }
   }