feat(ios): add inspectable for jscontext

Tencent · May 25, 2023 · e651e1b · e651e1b
1 parent fb29d4b
commit e651e1b
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 0 deletions.
diff --git a/ios/sdk/base/HippyBridge.h b/ios/sdk/base/HippyBridge.h
@@ -177,6 +177,12 @@ HIPPY_EXTERN NSString *HippyBridgeModuleNameForClass(Class bridgeModuleClass);
  */
 - (void)setRedBoxShowEnabled:(BOOL)enabled;
 
+/**
+ * Inspectable need to be set above ios16.4 system
+ * Default is YES for HIPPY_DEBUG mode
+ */
+- (void)setInspectable:(BOOL)isInspectable;
+
 /**
  * All registered bridge module classes.
  */

diff --git a/ios/sdk/base/HippyBridge.mm b/ios/sdk/base/HippyBridge.mm
@@ -432,6 +432,10 @@ - (void)setRedBoxShowEnabled:(BOOL)enabled {
 #endif  // HIPPY_DEBUG
 }
 
+- (void)setInspectable:(BOOL)isInspectable {
+    [self.batchedBridge.javaScriptExecutor setInspectable:isInspectable];
+}
+
 - (HippyOCTurboModule *)turboModuleWithName:(NSString *)name {
     return [self.batchedBridge turboModuleWithName:name];
 }

diff --git a/ios/sdk/base/HippyJavaScriptExecutor.h b/ios/sdk/base/HippyJavaScriptExecutor.h
@@ -69,6 +69,8 @@ typedef void (^HippyJavaScriptCallback)(id result, NSError *error);
  */
 - (void)flushedQueue:(HippyJavaScriptCallback)onComplete;
 
+- (void)setInspectable:(BOOL)inspectable;
+
 /**
  * called when second bundle load
  */

diff --git a/ios/sdk/base/executors/HippyJSCExecutor.mm b/ios/sdk/base/executors/HippyJSCExecutor.mm
@@ -390,6 +390,14 @@ - (JSContext *)JSContext {
         JSGlobalContextRef contextRef = [self JSGlobalContextRef];
         if (contextRef) {
             _JSContext = [JSContext contextWithJSGlobalContextRef:contextRef];
+#if HIPPY_DEBUG
+#if defined(__IPHONE_16_4) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_16_4
+            if (@available(iOS 16.4, *)) {
+                [_JSContext setInspectable:YES];
+            }
+#endif //defined(__IPHONE_16_4) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_16_4
+#endif //HIPPY_DEBUG
+
             HippyBridge *bridge = self.bridge;
             if ([bridge isKindOfClass:[HippyBatchedBridge class]]) {
                 bridge = [(HippyBatchedBridge *)bridge parentBridge];
@@ -503,6 +511,20 @@ - (void)secondBundleLoadCompleted:(BOOL)success {
 
 }
 
+- (void)setInspectable:(BOOL)inspectable {
+#if defined(__IPHONE_16_4) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_16_4
+    if (@available(iOS 16.4, *)) {
+        __weak HippyJSCExecutor *weakSelf = self;
+        [self executeBlockOnJavaScriptQueue:^{
+            HippyJSCExecutor *strongSelf = weakSelf;
+            if (strongSelf) {
+                [[strongSelf JSContext] setInspectable:inspectable];
+            }
+        }];
+    }
+#endif //defined(__IPHONE_16_4) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_16_4
+}
+
 - (void)updateGlobalObjectBeforeExcuteSecondary{
     if(![self.bridge.delegate respondsToSelector:@selector(objectsBeforeExecuteSecondaryCode)]){
         return;