fix(ios): fix view creation bug on release mode

Tencent · Dec 22, 2023 · ee057dc · ee057dc
1 parent e831f31
commit ee057dc
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/renderer/native/ios/renderer/HippyUIManager.mm b/renderer/native/ios/renderer/HippyUIManager.mm
@@ -149,7 +149,7 @@ - (void)removeAllObjects {
 @end
 
 static void NativeRenderTraverseViewNodes(id<HippyComponent> view, void (^block)(id<HippyComponent>)) {
-    if (view.hippyTag) {
+    if (view.hippyTag != nil) {
         block(view);
         for (id<HippyComponent> subview in view.subcomponents) {
             NativeRenderTraverseViewNodes(subview, block);
@@ -789,6 +789,7 @@ - (void)createRenderNodes:(std::vector<std::shared_ptr<DomNode>> &&)nodes
         }
         [superRenderObject didUpdateHippySubviews];
     }];
+    __block NSMutableArray *tempCreatedViews = [NSMutableArray arrayWithCapacity:nodes.size()]; // Used to temporarily hold views objects.
     for (const std::shared_ptr<DomNode> &node : nodes) {
         NSNumber *componentTag = @(node->GetId());
         HippyShadowView *shadowView = [_shadowViewRegistry componentForTag:componentTag onRootTag:rootNodeTag];
@@ -804,6 +805,7 @@ - (void)createRenderNodes:(std::vector<std::shared_ptr<DomNode>> &&)nodes
                         [uiManager->_componentTransactionListeners addObject:view];
                     }
                     [uiManager.viewRegistry addComponent:view forRootTag:shadowView.rootTag];
+                    [tempCreatedViews addObject:view];
                     
                     // TODO: hippy3 events binding handling, performance needs to be improved here.
                     const std::vector<std::string> &eventNames = [shadowView allEventNames];