Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): return size after loading gif #3001

Merged
merged 17 commits into from
Mar 8, 2023
Merged

fix(android): return size after loading gif #3001

merged 17 commits into from
Mar 8, 2023

Conversation

Xuanquan-Zhuang
Copy link
Contributor

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added doc: example framework: android size: s Denotes a PR that changes 10-99 lines labels Mar 2, 2023
@hippy-service
Copy link

hippy-service bot commented Mar 2, 2023

Hi, @Xuanquan-Zhuang. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

zoomchan-cxj
zoomchan-cxj requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 这个返回参数是否双端统一
  2. success都有哪些值，分别 表示什么意思，要在官网文档补充
  3. vue2、3 demo需要补充

@hippy-service
Copy link

hippy-service bot commented Mar 2, 2023

Hi, @Xuanquan-Zhuang, I noticed that our reviewers requested changes to this pull request.
When you're done, click the Re-request review button in the right sidebar(shown below) to notify the reviewer.
Re-request review button in the right sidebar

@github-actions github-actions bot added driver: js size: m Denotes a PR that changes 100-499 lines and removed size: s Denotes a PR that changes 10-99 lines labels Mar 3, 2023
@github-actions github-actions bot added size: s Denotes a PR that changes 10-99 lines and removed driver: js size: m Denotes a PR that changes 100-499 lines labels Mar 3, 2023
@Xuanquan-Zhuang Xuanquan-Zhuang requested review from zoomchan-cxj and iPel and removed request for zoomchan-cxj and iPel March 3, 2023 13:14
@github-actions github-actions bot added the size: m Denotes a PR that changes 100-499 lines label Mar 6, 2023
@github-actions github-actions bot removed the size: s Denotes a PR that changes 10-99 lines label Mar 6, 2023
@zoomchan-cxj zoomchan-cxj added the action(squash-merge) Squash and merge action label Mar 8, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) March 8, 2023 06:27
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Mar 8, 2023
@hippy-service
Copy link

hippy-service bot commented Mar 8, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zoomchan-cxj zoomchan-cxj added the action(squash-merge) Squash and merge action label Mar 8, 2023
@hippy-actions hippy-actions bot disabled auto-merge March 8, 2023 06:32
@hippy-actions hippy-actions bot enabled auto-merge (squash) March 8, 2023 06:32
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Mar 8, 2023
@hippy-actions hippy-actions bot merged commit a0976aa into Tencent:master Mar 8, 2023
zoomchan-cxj pushed a commit that referenced this pull request Mar 14, 2023
@Xuanquan-Zhuang @andrezhuang @zoomchan-cxj
fix(android): return size after loading gif (#3001)
02ba797 
* fix(android): return size after loading gif

* fix(vue, vue-next): handle onLoadEnd params

* Revert "fix(vue, vue-next): handle onLoadEnd params"

This reverts commit 52aae10.

* fix(android): return image size using onLoad

* fix(img): update demo about onLoad usage

* docs(img): update doc about onLoad usage

* fix(demo): modify attribute name

* fix(android): change if condition order

* fix(vue, vue-next): handle onLoadEnd params

* fix(vue, vue-next): remove unexpected events

* fix(vue, vue-next): modify code expression

* feat(react): update gif onLoad

* feat(vue, vue-next): update demo expression

---------

Co-authored-by: andrezhuang <andrezhuang@tencent.com>
zoomchan-cxj pushed a commit that referenced this pull request Mar 21, 2023
@Xuanquan-Zhuang @andrezhuang @zoomchan-cxj
fix(android): return size after loading gif (#3001)
28fdfa9 
* fix(android): return size after loading gif

* fix(vue, vue-next): handle onLoadEnd params

* Revert "fix(vue, vue-next): handle onLoadEnd params"

This reverts commit 52aae10.

* fix(android): return image size using onLoad

* fix(img): update demo about onLoad usage

* docs(img): update doc about onLoad usage

* fix(demo): modify attribute name

* fix(android): change if condition order

* fix(vue, vue-next): handle onLoadEnd params

* fix(vue, vue-next): remove unexpected events

* fix(vue, vue-next): modify code expression

* feat(react): update gif onLoad

* feat(vue, vue-next): update demo expression

---------

Co-authored-by: andrezhuang <andrezhuang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

@zoomchan-cxj zoomchan-cxj zoomchan-cxj approved these changes

@iPel iPel Awaiting requested review from iPel

Assignees
No one assigned
Labels
doc: example doc: pages driver: js framework: android size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xuanquan-Zhuang @iPel @zoomchan-cxj @siguangli @andrezhuang