Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): return size after loading gif #3001

Merged
merged 17 commits into from
Mar 8, 2023
Merged

fix(android): return size after loading gif #3001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
405cf70
fix(android): return size after loading gif
andrezhuang Mar 2, 2023
52aae10
fix(vue, vue-next): handle onLoadEnd params
andrezhuang Mar 3, 2023
63b83ff
Merge branch 'master' into fix/gif_size_callback
Xuanquan-Zhuang Mar 3, 2023
7457a90
Revert "fix(vue, vue-next): handle onLoadEnd params"
andrezhuang Mar 3, 2023
ca44e1d
fix(android): return image size using onLoad
andrezhuang Mar 3, 2023
7337657
fix(img): update demo about onLoad usage
andrezhuang Mar 3, 2023
f8a2f01
docs(img): update doc about onLoad usage
andrezhuang Mar 3, 2023
8f249b4
fix(demo): modify attribute name
andrezhuang Mar 3, 2023
b349204
fix(android): change if condition order
andrezhuang Mar 3, 2023
da7c2a2
Merge remote-tracking branch 'origin/fix/gif_size_callback' into fix/…
andrezhuang Mar 3, 2023
16cfcf8
fix(vue, vue-next): handle onLoadEnd params
andrezhuang Mar 6, 2023
3fb7dff
Merge branch 'master' into fix/gif_size_callback
Xuanquan-Zhuang Mar 6, 2023
08eefd5
fix(vue, vue-next): remove unexpected events
andrezhuang Mar 7, 2023
a200f83
Merge remote-tracking branch 'origin/fix/gif_size_callback' into fix/…
andrezhuang Mar 7, 2023
a47ab97
fix(vue, vue-next): modify code expression
andrezhuang Mar 7, 2023
cd2abad
feat(react): update gif onLoad
andrezhuang Mar 7, 2023
db525e1
feat(vue, vue-next): update demo expression
andrezhuang Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/sdk/src/main/java/com/tencent/mtt/hippy/views/image/HippyImageView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,12 @@ protected void handleGetImageSuccess() {
imageSize.pushInt("width", bitmap.getWidth());
imageSize.pushInt("height", bitmap.getHeight());
map.pushMap("image", imageSize);
} else if (mSourceDrawable instanceof HippyDrawable) {
zoomchan-cxj marked this conversation as resolved.
Show resolved Hide resolved
HippyDrawable hippyTarget = (HippyDrawable) mSourceDrawable;
HippyMap imageSize = new HippyMap();
imageSize.pushInt("width", hippyTarget.getWidth());
imageSize.pushInt("height", hippyTarget.getHeight());
map.pushMap("image", imageSize);
}
}
getOnLoadEndEvent().send(this, map);
Expand Down
7 changes: 5 additions & 2 deletions examples/hippy-react-demo/src/components/Image/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,11 @@ export default function ImageExpo() {
resizeMode={Image.resizeMode.cover}
defaultSource={defaultSource}
source={{ uri: 'https://user-images.githubusercontent.com/12878546/148736255-7193f89e-9caf-49c0-86b0-548209506bd6.gif' }}
onLoadEnd={() => {
console.log('gif onLoadEnd');
onLoadEnd={(result) => {
console.log(`gif onLoadEnd success: ${result.success}`);
if (result.success === 1) {
console.log(`gif size: ${result.image.width} * ${result.image.height}`);
}
}}
/>
</ScrollView>
Expand Down