Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hippy-react): fix declaration for animation and scroll-view #3510

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(hippy-react): fix declaration for animation and scroll-view #3510

merged 3 commits into from
Nov 16, 2023

Conversation

tomdyqin
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added driver: js size: s Denotes a PR that changes 10-99 lines labels Sep 13, 2023
@hippy-service
Copy link

hippy-service bot commented Sep 13, 2023

Hi, @tomdyqin. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Sep 13, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 16, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 16, 2023

After a quick scan, I have approved workflow to run.

@zealotchen0 zealotchen0 merged commit fadfc8c into Tencent:master Nov 16, 2023
18 of 21 checks passed
zealotchen0 pushed a commit that referenced this pull request Jul 18, 2024
@tomdyqin @zealotchen0
fix(hippy-react): fix declaration for animation and scroll-view (#3510)
3d8945c 
* fix(hippy-react): fix declaration for animation and scroll-view

* fix(hippy-react): fix declaration for web-view

* fix(hippy-react): fix ScrollViewEvent declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

Assignees
No one assigned
Labels
driver: js size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomdyqin @zealotchen0