Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hippy-react): Text component add forbidUnicodeToChar #3380

Merged
merged 3 commits into from
Jul 18, 2023
Merged

feat(hippy-react): Text component add forbidUnicodeToChar #3380

merged 3 commits into from
Jul 18, 2023

Conversation

maidishike
Copy link

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@tencent-adm
Copy link
Member

tencent-adm commented Jul 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added driver: js size: s Denotes a PR that changes 10-99 lines labels Jul 17, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 17, 2023

Hi, @maidishike. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jul 17, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Jul 17, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 17, 2023 09:32
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 17, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 18, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

auto-merge was automatically disabled July 18, 2023 13:05

Pull request was closed

@zealotchen0 zealotchen0 reopened this Jul 18, 2023
@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Jul 18, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 18, 2023 13:07
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 18, 2023
@hippy-actions hippy-actions bot merged commit 22f2e05 into Tencent:master Jul 18, 2023
zealotchen0 pushed a commit that referenced this pull request Jul 21, 2023
@maidishike @open-hippy @zealotchen0
feat(hippy-react): Text component add forbidUnicodeToChar (#3380)
979faf7 
* feat(hippy-react): Text component add forbidUnicodeToChar

* feat(hippy-react): Text component add forbidUnicodeToChar

---------

Co-authored-by: tobywanwan <tobywanwan@tencent.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

Assignees
No one assigned
Labels
doc: pages driver: js size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maidishike @tencent-adm @zealotchen0 @open-hippy