Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hippy-react): fix declaration and export it #3414

Merged
merged 7 commits into from
Aug 7, 2023
Merged

feat(hippy-react): fix declaration and export it #3414

merged 7 commits into from
Aug 7, 2023

Conversation

tomdyqin
Copy link
Contributor

@tomdyqin tomdyqin commented Jul 27, 2023 •
edited
Loading

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service
Copy link

hippy-service bot commented Jul 27, 2023

Hi, @tomdyqin. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@tomdyqin tomdyqin changed the base branch from main to master July 27, 2023 08:43
@ozonelmy ozonelmy removed their request for review July 29, 2023 03:13
zealotchen0
zealotchen0 previously approved these changes Aug 4, 2023
View reviewed changes
@zealotchen0 zealotchen0 changed the title Feature/react types feat(hippy-react): fix declaration and export it Aug 4, 2023
@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Aug 4, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 4, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-actions hippy-actions bot enabled auto-merge (squash) August 4, 2023 08:48
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Aug 4, 2023
auto-merge was automatically disabled August 4, 2023 10:13

Head branch was pushed to by a user without write access

@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Aug 6, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 6, 2023
View reviewed changes
scripts/copyright.js
const copyright = banner(undefined, undefined, undefined, undefined, false);
let fileContent;
if (replace) {
fileContent = content.replace(/\/\*(\s|.)*?\*\//, copyright);

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '/*' and containing many repetitions of '\t'.
@hippy-service
Copy link

hippy-service bot commented Aug 6, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-actions hippy-actions bot enabled auto-merge (squash) August 6, 2023 15:27
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Aug 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3414 (606f8f1) into master (9e7fb70) will increase coverage by 9.86%.
Report is 851 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3414      +/-   ##
==========================================
+ Coverage   62.36%   72.22%   +9.86%     
==========================================
  Files          30       67      +37     
  Lines        1990     4554    +2564     
  Branches        0      560     +560     
==========================================
+ Hits         1241     3289    +2048     
- Misses        749     1220     +471     
- Partials        0       45      +45

see 60 files with indirect coverage changes

@zealotchen0 zealotchen0 merged commit 593a11d into Tencent:master Aug 7, 2023
30 of 34 checks passed
zealotchen0 pushed a commit that referenced this pull request Aug 7, 2023
@tomdyqin @zealotchen0
feat(hippy-react): fix declaration and export it (#3414)
4e49d4f 
* feat(hippy-react): fix declaration and export it;

refactor list-view for extends

* feat(hippy-react): fix style declaration

* feat(hippy-react): add StyleSheet.flatten && fix style declaration

* feat(hippy-react): fix style declaration

* feat(hippy-react-web): fix text-input setStyle error

* feat(scripts): update copyright

* feat(scripts): update copyright force
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese

@etkmao etkmao Awaiting requested review from etkmao

@siguangli siguangli Awaiting requested review from siguangli

Assignees
No one assigned
Labels
build: js driver: js size: xl Denotes a PR that changes 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomdyqin @codecov-commenter @zealotchen0