Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): optimize fetch promise callback impl #3674

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix(android): optimize fetch promise callback impl #3674

merged 2 commits into from
Dec 21, 2023

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner December 20, 2023 07:47
@github-actions github-actions bot added framework: android size: s Denotes a PR that changes 10-99 lines labels Dec 20, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 20, 2023

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli merged commit b93618e into Tencent:main Dec 21, 2023
18 of 19 checks passed
@siguangli siguangli deleted the fix/handleFetchResponse branch December 21, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel Awaiting requested review from iPel iPel is a code owner

Assignees
No one assigned
Labels
framework: android size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siguangli @siguangli2018