Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/crosscompile #1466

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Feature/crosscompile #1466

merged 3 commits into from
Jan 4, 2025

Conversation

catundercar
Copy link
Contributor

Build multi platform golang package by Docker.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@catundercar
Copy link
Contributor Author

CLA assistant check Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Excuse me?
There seems to be a little problem with CLA:
image
@lingol

@lingol
Copy link
Collaborator

lingol commented Dec 31, 2024

CLA assistant check Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Excuse me? There seems to be a little problem with CLA: image @lingol

That's not reverent, you can ignore it.

@catundercar
Copy link
Contributor Author

CLA assistant check Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it. CLA assistant check 感谢您的提交,我们非常感激。与许多开源项目一样,我们要求您在贡献被接受之前签署我们的贡献者许可协议。您已经签署了 CLA,但状态仍为待定?让我们重新检查一下。

Excuse me? There seems to be a little problem with CLA: 打扰一下?CLA 似乎有点问题:image @lingol

That's not reverent, you can ignore it.那不重要,你可以忽略它。

👌

@lingol
Copy link
Collaborator

lingol commented Jan 1, 2025

Please respond to the review comments posted above.

@catundercar
Copy link
Contributor Author

Please respond to the review comments posted above.

Sorry, is this the comment you are talking about?
image
I tried to click recheck, and it responded 404. And when I tried to sign cla again, it timed out.

@lingol
Copy link
Collaborator

lingol commented Jan 1, 2025

No.

@lingol
Copy link
Collaborator

lingol commented Jan 1, 2025

#1466 (review)

Copy link
Contributor Author

@catundercar catundercar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add embed zlib and crc32_armv8, if not, there will be occurred a compile error:
image

@lingol
Copy link
Collaborator

lingol commented Jan 1, 2025

No, why as why did you remove the checking of system installed zlib?

@catundercar
Copy link
Contributor Author

No, why as why did you remove the checking of system installed zlib?

Because the environment in which the go package of mmkv is generated from source MMKV and the Go source code is compiled with cgo is different, when the environment that generates mmkv package has zlib, only two static library files will be output: libmmkv.a, libcore. A. At this time, when zlib does not exist in the environment where the Go source code is compiled using cgo, a compilation error will be reported.

@lingol
Copy link
Collaborator

lingol commented Jan 2, 2025

If that is the case you should make it a behavior controlled by some cmake argument passing in by your customized build script.

@catundercar
Copy link
Contributor Author

If that is the case you should make it a behavior controlled by some cmake argument passing in by your customized build script.

Ok, I got it. I will roll back the modifications to it.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lingol lingol merged commit beff34f into Tencent:dev Jan 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants