Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report]previewOnly模式下宽度没有占满父容器 #246

Closed
lshunran opened this issue Jun 7, 2022 · 2 comments
Closed

[Bug report]previewOnly模式下宽度没有占满父容器 #246

lshunran opened this issue Jun 7, 2022 · 2 comments
Labels
🐞bug Something isn't working
Milestone
0.7.5

Comments

@lshunran
Copy link

lshunran commented Jun 7, 2022

Describe the bug
在使用defaultModel: 'previewOnly'时，看到源码里固定了一个内联样式width: 50%，导致preview区域宽度恒为父容器的一半

To Reproduce
直接访问demo即可复现：https://tencent.github.io/cherry-markdown/examples/preview_only.html
image

Expected behavior
preview区域的宽度应于父容器宽度保持一致

Screenshots
image

Environment (please complete the following information):

  • Version 0.7.3
@lshunran lshunran changed the title [Bug report] [Bug report]previewOnly模式下宽度没有占满父容器 Jun 7, 2022
@humyfred humyfred added the 🐞bug Something isn't working label Jun 7, 2022
@humyfred
Copy link
Collaborator

humyfred commented Jun 7, 2022

收到，这两天会更新问题

@sunsonliu
Copy link
Collaborator

已修复，是 9f227e1 这个提交引入的问题，已回滚

@sunsonliu sunsonliu added this to the 0.7.3 milestone Jun 7, 2022
wty92911 pushed a commit to wty92911/cherry-markdown that referenced this issue May 22, 2023
@sunsonliu
fix: 只读模式下出现了两个问题(1、只读模式下宽度变成50%了；2、只读模式下可以编辑图片尺寸)
abd6cf4 
Fixed Tencent#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞bug Something isn't working
Projects
None yet
Milestone
0.7.5
Development

No branches or pull requests
3 participants
@sunsonliu @lshunran @humyfred