Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake #1823

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix cmake #1823

merged 1 commit into from
Jun 8, 2020

Conversation

wkcn
Copy link
Contributor

@wkcn wkcn commented Jun 8, 2020

Hi there,
When building ncnn, it outputs the following message:

CMake Error at src/CMakeLists.txt:413 (if):
  if given arguments:

    "DEFINED" "ANDROID_NDK_MAJOR" "AND" "GREATER" "20"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!

I try to fix it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #1823 into master will decrease coverage by 4.41%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
- Coverage   77.00%   72.58%   -4.42%     
==========================================
  Files         383      294      -89     
  Lines       53567    35708   -17859     
==========================================
- Hits        41251    25920   -15331     
+ Misses      12316     9788    -2528     
Impacted Files Coverage Δ
src/layer/x86/convolutiondepthwise_x86.cpp 57.60% <25.00%> (ø)
src/mat.h 60.36% <0.00%> (-12.35%) ⬇️
src/layer/crop.cpp 40.44% <0.00%> (-10.51%) ⬇️
src/layer/arm/convolution_1x1.h 56.50% <0.00%> (-4.42%) ⬇️
src/layer/noop.cpp 87.50% <0.00%> (-4.17%) ⬇️
src/layer/arm/convolution_3x3.h 49.12% <0.00%> (-3.89%) ⬇️
src/layer/arm/convolution_1x1_pack4to1.h 92.96% <0.00%> (-3.07%) ⬇️
src/layer/arm/convolution_1x1_pack4.h 93.58% <0.00%> (-2.93%) ⬇️
src/layer/arm/convolution_1x1_pack4to1_bf16s.h 90.06% <0.00%> (-2.31%) ⬇️
src/layer/arm/requantize_arm.cpp 37.20% <0.00%> (-1.93%) ⬇️
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d7e2c...30a4d65. Read the comment docs.

@nihui nihui merged commit c61a60b into Tencent:master Jun 8, 2020
@nihui
Copy link
Member

nihui commented Jun 8, 2020

赞美大佬!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants