Fix clang-cl.exe compatibility by using the correct cpuid intrinsics #4738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-cl.exe is designed to be the drop-in replacement of MSVC's cl.exe. Therefore,
_MSC_VER
preprocessor symbol is also defined by clang-cl.exe.However, some LLVM Clang's built-in functions (Intrinsics) are not compatible with MSVC. For example,
__cpuid()
is defined as:(Reference: https://clang.llvm.org/doxygen/cpuid_8h_source.html)
Therefore, we need to use
__get_cpuid
instead of__cpuid
when using clang-cl.exe