Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_gpu_instance: do not perform destroy_gpu_instance() #5437

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Asd-g
Copy link
Contributor

@Asd-g Asd-g commented Apr 19, 2024

When performing destroy_gpu_instance(), g_instance.created is always 0.

When performing destroy_gpu_instance(), g_instance.created is always 0.
@github-actions github-actions bot added the core label Apr 19, 2024
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (6cdd711) to head (42de2cc).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5437    +/-   ##
========================================
  Coverage   94.52%   94.52%            
========================================
  Files         780      780            
  Lines      243658   243552   -106     
========================================
- Hits       230314   230215    -99     
+ Misses      13344    13337     -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihui nihui merged commit bbf2e5d into Tencent:master Jun 4, 2024
66 of 67 checks passed
@nihui
Copy link
Member

nihui commented Jun 4, 2024

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants