Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define empty assertion termination function for fixing linking with old android ndk #5847

Merged
merged 2 commits into from
Dec 25, 2024
Merged

define empty assertion termination function for fixing linking with old android ndk #5847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36423c
define empty assertion termination function for fixing linking with o…
nihui Dec 24, 2024
16f5143
w
nihui Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,12 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
endif()
endif()

if(ANDROID_NDK_MAJOR AND (ANDROID_NDK_MAJOR GREATER_EQUAL 27))
# llvm 18 in ndk-27 introduce __libcpp_verbose_abort for assertion output
# define empty body for fixing linking issue with old ndk
add_definitions("-D_LIBCPP_VERBOSE_ABORT\\(format,args...\\)=")
endif()

if(NCNN_VULKAN)
if(NCNN_SYSTEM_GLSLANG)
find_package(Threads)
Expand Down Expand Up @@ -766,6 +772,10 @@ if(NCNN_VULKAN)
# glslang requires c++11
set(CMAKE_CXX_STANDARD 11)

# remove ostream usage in glslang for better libcpp abi compatibility
include(cmake/glslang_drop_ostream.cmake)
glslang_drop_ostream(${CMAKE_CURRENT_LIST_DIR}/glslang)

option(BUILD_EXTERNAL "" OFF)
option(ENABLE_SPVREMAPPER "" OFF)
option(ENABLE_GLSLANG_BINARIES "" OFF)
Expand Down
42 changes: 42 additions & 0 deletions cmake/glslang_drop_ostream.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# this cmake script remove ostream usage in glslang

function(glslang_drop_ostream GLSLANG_ROOT)

# patch glslang/SPIRV/GlslangToSpv.h
file(STRINGS ${GLSLANG_ROOT}/SPIRV/GlslangToSpv.h GlslangToSpv_HDR)
file(WRITE ${GLSLANG_ROOT}/SPIRV/GlslangToSpv.h "")
foreach(LINE IN LISTS GlslangToSpv_HDR)
if(LINE MATCHES "^bool OutputSpvBin(.*);" OR LINE MATCHES "^bool OutputSpvHex(.*);")
continue()
endif()

file(APPEND ${GLSLANG_ROOT}/SPIRV/GlslangToSpv.h "${LINE}\n")
endforeach()

# patch glslang/SPIRV/GlslangToSpv.cpp
file(STRINGS ${GLSLANG_ROOT}/SPIRV/GlslangToSpv.cpp GlslangToSpv_SRC)
file(WRITE ${GLSLANG_ROOT}/SPIRV/GlslangToSpv.cpp "")
foreach(LINE IN LISTS GlslangToSpv_SRC)
if(LINE MATCHES "^bool OutputSpvBin(.*)")
set(GlslangToSpv_SRC_OutputSpvBin TRUE)
endif()
if(LINE MATCHES "^bool OutputSpvHex(.*)")
set(GlslangToSpv_SRC_OutputSpvHex TRUE)
endif()

if(GlslangToSpv_SRC_OutputSpvBin OR GlslangToSpv_SRC_OutputSpvHex)
if(LINE MATCHES "^}$")
if(GlslangToSpv_SRC_OutputSpvBin)
unset(GlslangToSpv_SRC_OutputSpvBin)
endif()
if(GlslangToSpv_SRC_OutputSpvHex)
unset(GlslangToSpv_SRC_OutputSpvHex)
endif()
endif()
continue()
endif()

file(APPEND ${GLSLANG_ROOT}/SPIRV/GlslangToSpv.cpp "${LINE}\n")
endforeach()

endfunction()
Loading