Switch to putenv to fix compilation with llvm-mingw #6101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `setenv` with `putenv` because `setenv` is not available on some toolchains (e.g., llvm-mingw, clang-cl), leading to compilation errors.
Member
|
|
|
The binary size change of libncnn.so (bytes)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6101 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 827 827
Lines 270161 270161
=======================================
Hits 258562 258562
Misses 11599 11599 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces POSIX setenv calls with putenv to resolve build errors on toolchains lacking setenv (e.g., llvm-mingw, clang-cl).
- Swaps two
setenvinvocations forputenvin the OpenMP environment initializer. - Ensures environment variables
KMP_AFFINITYandKMP_DUPLICATE_LIB_OKare set on startup.
Member
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
setenvwithputenvbecausesetenvis not available on some toolchains (e.g., llvm-mingw, clang-cl), leading to compilation errors.