Skip to content

Conversation

@bil0077
Copy link
Contributor

@bil0077 bil0077 commented Jul 25, 2025

No description provided.

@tencent-adm
Copy link
Member

tencent-adm commented Jul 25, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

The binary size change of libncnn.so (bytes)

architecture base size pr size difference
x86_64 15643128 15643128 0 😘
armhf 6648220 6648220 0 😘
aarch64 9986896 9986896 0 😘

@nihui nihui requested a review from Copilot July 25, 2025 06:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Windows CI workflow from using a matrix of different Windows runners (windows-2019 and windows-2022) to exclusively use windows-2022, requiring additional setup steps to support older Visual Studio toolsets.

  • Consolidates all builds to run on windows-2022 instead of using different OS versions
  • Adds installation steps for VS 2015 and VS 2017 build tools since they're not pre-installed on windows-2022
  • Splits a long cmake command into multiple lines for better readability

@nihui nihui merged commit b039b87 into Tencent:master Jul 25, 2025
11 checks passed
@nihui
Copy link
Member

nihui commented Jul 25, 2025

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants