Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UE]修复在windows下使用远程IOS编译，变量名重名导致的编译失败 #1626

Merged
merged 2 commits into from
Jan 5, 2024
Merged

[UE]修复在windows下使用远程IOS编译，变量名重名导致的编译失败 #1626

merged 2 commits into from
Jan 5, 2024

Conversation

RookieInsect
Copy link
Contributor

[UE]修复window使用远程打包mac编译失败，变量重名问题

@RookieInsect
Update JsEnvImpl.cpp
1cdc180 
修复mac编译失败
@RookieInsect RookieInsect changed the title Update JsEnvImpl.cpp [UE]修复在windows下使用远程IOS编译，变量名重名导致的编译失败 Jan 4, 2024
@chexiongsheng
Copy link
Collaborator

这是个局部变量呢，和哪个变量名重名呢？

@RookieInsect
Copy link
Contributor Author

jsEnvImpl.cpp 332行
#if PLATFORM_IOS
char Flags[] = "--jitless --no-expose-wasm";
v8::V8::SetFlagsFromString(Flags, sizeof(Flags));
#endif

@chexiongsheng chexiongsheng merged commit 3cab273 into Tencent:master Jan 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RookieInsect @chexiongsheng