Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pretty" example is much slower than YAJL's reformat #2

Closed
miloyip opened this issue Jun 6, 2014 · 2 comments
Closed

"pretty" example is much slower than YAJL's reformat #2

miloyip opened this issue Jun 6, 2014 · 2 comments

Comments

@miloyip
Copy link
Collaborator

miloyip commented Jun 6, 2014

From milo...@gmail.com on November 22, 2011 11:31:26

https://github.com/lloyd/yajl_vs_rapidjson This contradicts the results shown in https://code.google.com/p/rapidjson/wiki/Performance

Original issue: http://code.google.com/p/rapidjson/issues/detail?id=1

@miloyip
Copy link
Collaborator Author

miloyip commented Jun 6, 2014

From milo...@gmail.com on November 21, 2011 19:32:54

the performance problem of pretty example should be mainly due to FileStream?, which uses fgetc(). And I will add another stream classes with buffers and using fread()/fwrite().

The https://code.google.com/p/rapidjson/wiki/Performance is aimed at testing parsing/generating performance, reading of source JSON string are excluded in the measurement.

However, I will fix the performance issues in examples soon, and gives results as well.

@miloyip
Copy link
Collaborator Author

miloyip commented Jun 6, 2014

From milo...@gmail.com on November 13, 2012 20:17:33

Revision r23 has modified pretty to use the new file stream. Need to rerun Lloyd's test.

Status: Fixed
Blockedon: -rapidjson:3 rapidjson:3

@miloyip miloyip closed this as completed Jun 6, 2014
@xinthose xinthose mentioned this issue Aug 19, 2015
miloyip pushed a commit that referenced this issue Mar 16, 2017
miloyip pushed a commit that referenced this issue Jul 9, 2021
…alidation-messages

Multiple validation failures and validation messages
miloyip pushed a commit that referenced this issue Oct 15, 2021
lgleim added a commit to lgleim/rapidjson that referenced this issue Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant