Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericStringRef::operator= does not compile #718

Closed
yachoor opened this issue Aug 26, 2016 · 1 comment
Closed

GenericStringRef::operator= does not compile #718

yachoor opened this issue Aug 26, 2016 · 1 comment

Comments

@yachoor
Copy link
Contributor

yachoor commented Aug 26, 2016

GenericStringRef::operator= tries to assign values to constant members, failing to compile:

rapidjson::GenericStringRef<char> a("");
rapidjson::GenericStringRef<char> b("");
a = b;

generates errors:
error: assignment of read-only member 'rapidjson::GenericStringRef::s'
error: assignment of read-only member 'rapidjson::GenericStringRef::length'

Unfortunately one of the compilers I use is overeager with member functions of templates and fails compilation even if it is never called :(
Since it doesn't compile anyways and compiler-generated default one will fail the same I think it can be safely deleted.

@miloyip
Copy link
Collaborator

miloyip commented Aug 29, 2016

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants