GenericDocument::ParseStream: make SourceEncoding optional #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ParseStream() function current requires explicitly passing the SourceEncoding parameter as explicit template argument while the other Parse*() functions provide overloads to omit this parameter and use the document's own encoding by default. This patch adds the corresponding overload for ParseStream(), enabling the simple usage again: rapidjson::FileStream is(fp); rapidjson::Document d; d.ParseStream<0>(is);
miloyip
added a commit
that referenced
this pull request
Jun 25, 2014
GenericDocument::ParseStream: make SourceEncoding optional
Closed
Closed
This was referenced Jan 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ParseStream() function current requires explicitly passing
the SourceEncoding parameter as explicit template argument
while the other Parse*() functions provide overloads to omit
this parameter and use the document's own encoding by default.
This patch adds the corresponding overload for ParseStream(),
enabling the simple usage again:
rapidjson::FileStream is(fp);
rapidjson::Document d;
d.ParseStream<0>(is);
This fixes upstream issue 107 again (see 84f64ba).