Fix #1721 #1817
Merged
Fix #1721 #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleting the constructors causes warnings with g++ which are treated as errors, so I'm adding empty bodies to the constructors/assignment operators. |
|
Thank you |
ASpoonPlaysGames
added a commit
to ASpoonPlaysGames/NorthstarLauncher
that referenced
this pull request
Jan 21, 2024
ASpoonPlaysGames
added a commit
to ASpoonPlaysGames/NorthstarLauncher
that referenced
this pull request
Jan 21, 2024
GeckoEidechse
pushed a commit
to R2Northstar/NorthstarLauncher
that referenced
this pull request
Jan 21, 2024
* fix C5054 (cherry-pick change from Tencent/rapidjson#1817) * fix C4099 in Rapidjson. Cherry-picks the following: Tencent/rapidjson@d87b698 Tencent/rapidjson#1568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1721. I also deleted the copy constructor and copy assignment of
SchemaDocumentProviderintest/unittest/schematest.cppbecause they don't have function bodies. I'm not sure if this'll create issues for other platforms, but for MSVC having those definition causes problems.