Fix UB in GenericDocument::ParseStream #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check is it possible to expose allocator.
miloyip
added a commit
that referenced
this pull request
Sep 19, 2015
Fix UB in GenericDocument::ParseStream
|
Thank you |
pah
added a commit
to pah/rapidjson-upstream
that referenced
this pull request
Nov 16, 2015
…encent#469) In the MoveConstructor/MoveAssignment tests, a check for a `NULL` allocator return has been used to check for the correct moved-from state of a Document. After the merge of Tencent#426, the GetAllocator call fails with an assertion, if the allocator of a GenericDocument is NULL. Check for the throw, instead of NULL in the move-related tests. Tested with GCC 4.9 on Linux with C++11 enabled. Reported-by: @woldendans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #425