Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding coapp definition #460

Merged
merged 3 commits into from
Oct 30, 2015
Merged

Adding coapp definition #460

merged 3 commits into from
Oct 30, 2015

Conversation

stunney
Copy link
Contributor

@stunney stunney commented Oct 29, 2015

To create a nupkg, call CoApp's Write-NuGetPackage .\rapidjson.autopkg
-defines:MYVERSION=1.0.2 (or whatever version you want to call it)

To create a nupkg, call CoApp's Write-NuGetPackage .\rapidjson.autopkg
-defines:MYVERSION=1.0.2 (or whatever version you want to call it)
@miloyip
Copy link
Collaborator

miloyip commented Oct 29, 2015

Will it be better using https://github.com/miloyip/rapidjson/blob/master/license.txt as licenseUrl?

@stunney
Copy link
Contributor Author

stunney commented Oct 29, 2015

Yes, yes it would. :)

Sent from Yahoo Mail on Android

From:"Milo Yip" notifications@github.com
Date:Thu, 29 Oct, 2015 at 12:15
Subject:Re: [rapidjson] Adding coapp definition (#460)

Will it be better using https://github.com/miloyip/rapidjson/blob/master/license.txt as licenseUrl?


Reply to this email directly or view it on GitHub.

@Kosta-Github
Copy link
Contributor

Maybe you can add the sample commandline invokation as a comment to the package def file as well?

@stunney
Copy link
Contributor Author

stunney commented Oct 29, 2015

@Kosta-Github you mean as a comment at the top of the .autopkg file?

Adding usage comment at the top of the file for knowledge sharing
@stunney
Copy link
Contributor Author

stunney commented Oct 29, 2015

@Kosta-Github I have added comments to the top of the .autopkg file

miloyip added a commit that referenced this pull request Oct 30, 2015
@miloyip miloyip merged commit b39a898 into Tencent:master Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants