drop trailing commas in enums #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++'98/03, trailing commas in enumerations are not allowed, but have been introduced in C++11. This patch drops the trailing commas in order to avoid compiler warnings (e.g. GCC with -pedantic). Fixes http://code.google.com/p/rapidjson/issues/detail?id=49.
pah
added a commit
to pah/rapidjson-upstream
that referenced
this pull request
Nov 24, 2014
With `-Werror=pedantic`
[...]/include/rapidjson/error/error.h:88:37: error: comma at end of enumerator list [-Werror=pedantic]
kParseErrorUnspecificSyntaxError, //!< Unspecific syntax error.
Drop trailing comma to fix this. See Tencent#9.
pah
added a commit
to pah/rapidjson-upstream
that referenced
this pull request
Feb 20, 2015
In C++'98/03, trailing commas in enumerations are not allowed, but have been introduced in C++11. This patch drops the trailing commas in order to avoid compiler warnings (e.g. GCC with -pedantic). See Tencent#9 and http://code.google.com/p/rapidjson/issues/detail?id=49 for previous instances of this issue.
Closed
This was referenced May 16, 2017
Closed
This was referenced Jan 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++'98/03, trailing commas in enumerations are not allowed, but have
been introduced in C++11. This patch drops the trailing commas in order
to avoid compiler warnings (e.g. GCC with -pedantic).
Fixes http://code.google.com/p/rapidjson/issues/detail?id=49.