Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): resolve colspan handling for multi-header #4669

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

wangyang0210
Copy link
Contributor

@wangyang0210 wangyang0210 commented Oct 21, 2024

Added support for multi-header to ensure correct colspan calculation for child columns.

closed #4667

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#4667

💡 需求背景和解决方案

  1. 多级表头下的表头通过colspan进行合并
  2. thead.tsx下的colspanSkipMap函数下,增加children的处理逻辑

📝 更新日志

  • fix(Table): 多级表头下的通过colspan合并表头

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Added support for multi-header to ensure correct colspan calculation for child columns.

closed Tencent#4667
Copy link
Contributor

github-actions bot commented Oct 21, 2024

完成

src/table/thead.tsx Outdated Show resolved Hide resolved
src/table/thead.tsx Outdated Show resolved Hide resolved
@uyarn uyarn closed this Oct 21, 2024
@uyarn uyarn reopened this Oct 21, 2024
@uyarn
Copy link
Collaborator

uyarn commented Oct 21, 2024

reopen to retrigger CI

Add handling for child columns (children), recursively calling the processColumns function.
@wangyang0210
Copy link
Contributor Author

针对上面两处性能问题,已经进行过处理。

@uyarn uyarn merged commit d4445b3 into Tencent:develop Oct 24, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Table】多级表头下的表头合并
3 participants