Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/layout tsx to sfc #157

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

zhangpaopao0609
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 重构

🔗 相关 Issue

统一使用sfc编写组件:#156

💡 需求背景和解决方案

  1. menuContent.tsx to MenuContent.vue
  2. sideNav.tsx to SideNav.vue
  3. layout/index.tsx to index.vue

其中为了能在 layout/index.vue 中复用组件,在 layout/components 中新增了 LayoutHeader、LayoutSidebar 和 LayoutContent 组件

📝 更新日志

  • refactor: layouts 中 tsx 文件统一为 sfc

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Sorry, something went wrong.

@github-actions
Copy link

github-actions bot commented Aug 10, 2022

完成

@zhangpaopao0609 zhangpaopao0609 force-pushed the feature/layout-tsx-to-sfc branch 2 times, most recently from 309fef4 to e0ce5c8 Compare August 10, 2022 03:12

Verified

This commit was signed with the committer’s verified signature.
bradtgmurray Brad Murray

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@zhangpaopao0609 zhangpaopao0609 force-pushed the feature/layout-tsx-to-sfc branch from e0ce5c8 to fbc013a Compare August 10, 2022 03:14
@zhangpaopao0609
Copy link
Contributor Author

已修改 commit 提交信息

@uyarn uyarn merged commit fb85f86 into Tencent:develop Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants