Allow ScaleImage to create its own texture cache and remove unnecessary sampling parameters. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry sampling parameters.
domchen
requested review from
kevingpqi123,
Hparty,
lvpengwei and
shlzxjp
as code owners
Hparty
reviewed
Nov 28, 2024
| } | ||
| } | ||
| auto flattenImage = | ||
| std::shared_ptr<FlattenImage>(new FlattenImage(UniqueKey::Make(), std::move(source))); |
There was a problem hiding this comment.
FlattenImage是不是和MipmapImage一样，用一个固定key来处理UniqueKey比较好？
Hparty
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
允许ScaleImage创建独立的纹理缓存，因为Image不再存在未应用的缩放，大部分lockTextureProxy方法也都可以移除不必要的sampling参数。