Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use android.jar as bootstrapClasspath #1646

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

shifujun
Copy link

Some projects like aosp-dexutils are using java-library plugin,
but they are used in Android platform.
That means it compiled against standard JDK, maybe JDK11,
but run under android.jar.

We should set android.jar as bootstrapClasspath of javac,
like com.android.library did.

Before this commit:

#verify use JDK11
javac --version
javac 11.0.11

#compile a java-library project
./gradlew :third-party:aosp-dexutils:compileJava
BUILD SUCCESSFUL

# disassemble class and check target method signature
javap -c -verbose third-party/aosp-dexutils/build\
/classes/java/main/com/tencent/tinker/android/dex/Dex.class \
| grep 'Method java/nio/ByteBuffer.position'

# output contains:
java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer;

After this commit, output change to:

java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;

Some projects like `aosp-dexutils` are using `java-library` plugin,
but they are used in Android platform.
That means it compiled against standard JDK, maybe JDK11,
but run under android.jar.

We should set android.jar as bootstrapClasspath of javac,
like `com.android.library` did.

Before this commit:
```
#verify use JDK11
javac --version
javac 11.0.11

#compile a java-library project
./gradlew :third-party:aosp-dexutils:compileJava
BUILD SUCCESSFUL

# disassemble class and check target method signature
javap -c -verbose third-party/aosp-dexutils/build\
/classes/java/main/com/tencent/tinker/android/dex/Dex.class \
| grep 'Method java/nio/ByteBuffer.position'

# output contains:
java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer;
```

After this commit, output change to:
```
java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant