Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable gamestatefulset scheme default setting #1176

Merged
merged 1 commit into from
Dec 17, 2021
Merged

fix: enable gamestatefulset scheme default setting #1176

merged 1 commit into from
Dec 17, 2021

Conversation

adevjoe
Copy link
Contributor

@adevjoe adevjoe commented Dec 16, 2021

修复 gamestatefulset 对象默认值失效的问题,默认值失效会导致未设置 spec.updateStrategy.type 时,不能以 OnDelete 策略创建新 Pod。

@xcming
Copy link
Collaborator

xcming commented Dec 16, 2021

和 operator-framework 这个 PR 比较像,也是定义了 sheme 默认值函数,然后没有被调用,通过显式调用暂时解决。
目前推荐的方法是通过 webhook 方式,或者 v1 版本的 crd 中添加默认值。 @wenxinlee2015 确认下是否暂时先采用显式调用方法后续再进行升级?

@wenxinlee2015
Copy link
Collaborator

我认为可以通过显示调用解决,关注下回归测试、关注下另2个controller是否需同样处理。
后续升级尽量走crd默认添加,不走webhook避免组件依赖造成复杂度提升。

@wenxinlee2015 wenxinlee2015 merged commit a8a5648 into TencentBlueKing:master Dec 17, 2021
@adevjoe adevjoe deleted the fix-gamestatefulset-default branch January 10, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants