增加构建详情的查看配置项，在构建详情界面点击插件时，默认进入的是 日志 or 配置 Tab页面。 #10808 #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 16458
useryuyu
requested review from
lockiechen,
terlinhe and
zhanxu33
as code owners
|
|
# Reviewed, transaction id: 18494
useryuyu
force-pushed
the
issue_10808
branch
from
e9d49ac to
e6961e7
Compare
…o issue_10808 # Reviewed, transaction id: 18496
# Reviewed, transaction id: 18511
lockiechen
reviewed
Sep 18, 2024
| @@ -132,6 +132,7 @@ | |||
| <plugin | |||
| :exec-detail="execDetail" | |||
| :editing-element-pos="editingElementPos" | |||
| :properties="['CONFIG', 'LOG', 'ARTIFACT']" | |||
There was a problem hiding this comment.
数组，对象这种不要直接写在属性里面，这样每次diff都会导致Props不一致， 用一个computed属性存起来
# Reviewed, transaction id: 18660
# Reviewed, transaction id: 18662
lockiechen
reviewed
Sep 18, 2024
| }, | ||
| properties: { | ||
| handler (newValue) { | ||
| if (JSON.stringify(newValue) === JSON.stringify(['CONFIG', 'LOG', 'ARTIFACT'])) { |
There was a problem hiding this comment.
不要用这种方式直接去比较数组是否一致，虽然这个数组长度不多，问题不大，同样的原理，这种用join性能还好一些
newValue.join('') === ['CONFIG', 'LOG', 'ARTIFACT'].join(''), 而且我看这个默认值出现多次了，可以统一用个变量存起来，也后续方便维护
# Reviewed, transaction id: 18879
lockiechen
approved these changes
Sep 20, 2024
…o issue_10808 # Reviewed, transaction id: 21647
# Reviewed, transaction id: 21709
lockiechen
reviewed
Oct 24, 2024
| @@ -257,6 +257,7 @@ | |||
| return ['RUNNING', 'QUEUE'].includes(this.execDetail?.status) | |||
| }, | |||
| panels () { | |||
| console.log(this.execDetail, '------------------', this.curProject) | |||
# Reviewed, transaction id: 21752
# Reviewed, transaction id: 21851
# Reviewed, transaction id: 21886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10808