feat: 引擎等MQ场景接入SCS框架 #7443 #10955
Merged
feat: 引擎等MQ场景接入SCS框架 #7443 #10955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/service/PipelineStageService.kt # src/backend/ci/core/process/biz-engine/src/test/kotlin/com/tencent/devops/process/engine/control/MutexControlTest.kt
# Conflicts: # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/api/external/ExternalScmResourceImpl.kt
# Conflicts: # src/backend/ci/core/auth/biz-auth/src/main/kotlin/com/tencent/devops/auth/provider/rbac/config/RbacMQConfiguration.kt # src/backend/ci/core/common/common-event/src/main/kotlin/com/tencent/devops/common/event/dispatcher/pipeline/mq/MQ.kt # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/plugin/trigger/configuration/TriggerConfiguration.kt
# Conflicts: # src/backend/ci/core/auth/biz-auth/src/main/kotlin/com/tencent/devops/auth/provider/rbac/config/RbacMQConfiguration.kt # src/backend/ci/core/common/common-event/src/main/kotlin/com/tencent/devops/common/event/dispatcher/pipeline/mq/MQ.kt # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/plugin/trigger/configuration/TriggerConfiguration.kt
# Conflicts: # src/backend/ci/core/common/common-dispatch-sdk/src/main/kotlin/com/tencent/devops/common/dispatch.sdk/listener/BuildListener.kt # src/backend/ci/core/common/common-dispatch-sdk/src/main/kotlin/com/tencent/devops/common/dispatch.sdk/service/DispatchService.kt # src/backend/ci/core/common/common-event/src/main/kotlin/com/tencent/devops/common/event/dispatcher/pipeline/mq/MQ.kt # src/backend/ci/core/dispatch/biz-dispatch/src/main/kotlin/com/tencent/devops/dispatch/service/ThirdPartyDispatchService.kt # src/backend/ci/core/metrics/biz-metrics/src/main/kotlin/com/tencent/devops/metrics/config/MetricsListenerConfiguration.kt # src/backend/ci/core/process/biz-engine/src/main/kotlin/com/tencent/devops/process/engine/atom/vm/DispatchVMStartupTaskAtom.kt
stubenhuang
requested review from
irwinsun,
mingshewhe,
royalhuang,
randychen2046 and
tangruotian
as code owners
irwinsun
reviewed
Oct 15, 2024
irwinsun
reviewed
Oct 15, 2024
...ocket/biz-websocket/src/main/kotlin/com/tencent/devops/websocket/servcie/WebsocketService.kt
Show resolved
Hide resolved
irwinsun
reviewed
Oct 15, 2024
...core/common/common-event/src/test/kotlin/com/tencent/devops/common/event/util/IPUtilsTest.kt
Outdated
Show resolved
Hide resolved
royalhuang
approved these changes
Oct 15, 2024
mingshewhe
approved these changes
Oct 16, 2024
| @@ -30,6 +30,7 @@ dependencies { | |||
| api(project(":core:common:common-client")) | |||
| api(project(":core:common:common-event")) | |||
| api(project(":core:common:common-db")) | |||
| api(project(":core:common:common-dispatch-sdk")) | |||
There was a problem hiding this comment.
auth应该不需要引common-dispatch-sdk
| fun pipelineBuildStartListener( | ||
| @Autowired buildControl: BuildStartControl, | ||
| @Autowired pipelineEventDispatcher: PipelineEventDispatcher | ||
| ) = PipelineBuildStartListener( |
| @Autowired webhookListener: PipelineWebHookQueueListener, | ||
| @Autowired notifyListener: PipelineNotifyQueueListener | ||
| ) = ScsConsumerBuilder.build<PipelineBuildFinishBroadCastEvent> { | ||
| webhookListener.onBuildFinish(it) |
There was a problem hiding this comment.
webhookQueue和notify的功能完全不同,建议队列还是分开
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7443