feat：stage 审核支持 checklist 确认场景 #10920 #10981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 18371
…o issue_10920 # Reviewed, transaction id: 18374
useryuyu
requested review from
lockiechen,
terlinhe and
zhanxu33
as code owners
lockiechen
reviewed
Sep 20, 2024
| if (isBooleanParam(type)) this.copyForm.value = false | ||
| if (isBooleanParam(type)) this.copyForm.value = '' | ||
|
|
||
| if (isCheakboxParam(type)) this.copyForm.value = false |
There was a problem hiding this comment.
这里改一下，改成switch, 或者是if else if这种，没必要走三个判断，
# Reviewed, transaction id: 18884
lockiechen
approved these changes
Sep 20, 2024
# Reviewed, transaction id: 18918
…o issue_10920 # Reviewed, transaction id: 18956
# Reviewed, transaction id: 18983
lockiechen
approved these changes
Sep 23, 2024
…o issue_10920 # Reviewed, transaction id: 20626
# Reviewed, transaction id: 20678
# Reviewed, transaction id: 20719
# Reviewed, transaction id: 20769
…o issue_10920 # Reviewed, transaction id: 20791
# Reviewed, transaction id: 20792
# Reviewed, transaction id: 20804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10920