Merge pull request #2264 from wangyu096/issue_2263

fix: 脚本管理页面，批量编辑标签报错 #2263
TencentBlueKing · Jul 21, 2023 · 451e9b3 · 451e9b3
2 parents 8a6c541 + 10fc24e
commit 451e9b3
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/...ob-manage/src/main/java/com/tencent/bk/job/manage/api/web/impl/WebScriptResourceImpl.java b/...ob-manage/src/main/java/com/tencent/bk/job/manage/api/web/impl/WebScriptResourceImpl.java
@@ -1093,6 +1093,11 @@ public Response<?> batchUpdateScriptTags(String username,
             return Response.buildValidateFailResp(validateResult);
         }
 
+        if (CollectionUtils.isEmpty(req.getAddTagIdList()) && CollectionUtils.isEmpty(req.getDeleteTagIdList())) {
+            // do nothing
+            return Response.buildSuccessResp(true);
+        }
+
         boolean isPublicScript = appResourceScope == null;
         List<String> scriptIdList = req.getIdList();
         AuthResult authResult;
@@ -1131,12 +1136,6 @@ private ValidateResult checkScriptTagBatchPatchReq(ScriptTagBatchPatchReq req) {
             log.warn("ScriptTagBatchUpdateReq->idList is empty");
             return ValidateResult.fail(ErrorCode.ILLEGAL_PARAM_WITH_PARAM_NAME, "idList");
         }
-
-        if (CollectionUtils.isEmpty(req.getAddTagIdList()) && CollectionUtils.isEmpty(req.getDeleteTagIdList())) {
-            log.warn("ScriptTagBatchUpdateReq->No script tags changed!");
-            return ValidateResult.fail(ErrorCode.ILLEGAL_PARAM_WITH_PARAM_NAME,
-                "addTagIdList|deleteTagIdList");
-        }
         return ValidateResult.pass();
     }