perf: 脚本列表，脚本语言的排序需要按照语言名称的字典顺序 #1317 #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonwan
reviewed
Sep 22, 2022
| // ScriptTypeEnum | ||
| if (baseSearchCondition.getOrder() == Order.ASCENDING.getOrder()) { | ||
| // 按照脚本语言名称字典顺序排序.Bat(2)->Perl(3)->Powershell(5)->Python(4)->Shell(1)->SQL(6) | ||
| orderFields.add(DSL.field("field({0},2,3,5,4,1,6)", TB_SCRIPT.TYPE).asc()); |
There was a problem hiding this comment.
特殊顺序的逻辑是否可以内聚到枚举类型中去，将来增加/修改枚举值时能够及时发现一并修改，放在这里是弱关联
jsonwan
reviewed
Sep 22, 2022
| } else { | ||
| orderFields.add(TB_SCRIPT.TYPE.desc()); | ||
| orderFields.add(DSL.field("field({0},2,3,5,4,1,6)", TB_SCRIPT.TYPE).desc()); |
jsonwan
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.