Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 无权限提示信息带上用户名 #784 #1645

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

liuliaozhong
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@jsonwan jsonwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorCode文件第323、325行的注释请一并修改,加上占位符

1238001=Insufficient user permissions
9900403=Insufficient user permissions
1238001=Insufficient user {0} permissions
9900403=Insufficient user {0} permissions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文文案与产品沟通确认后看看是否需要修改,直接加在user后面不太通顺

Copy link
Collaborator

@jsonwan jsonwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2个问题需要处理下

@liuliaozhong liuliaozhong requested a review from jsonwan January 3, 2023 08:53
@jsonwan jsonwan merged commit 4274768 into TencentBlueKing:3.5.x Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants