Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 增加GSE任务结果响应中的agentId(ip)不正确的错误日志 #2165 #2166

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

wangyu096
Copy link
Collaborator

#2165

  1. 日志优化:如果 GSE 返回结果中的 agentId(ip) 不存在,会打印 WARN 日志
  2. 相关代码位置调整,更符合逻辑

@wangyu096 wangyu096 requested a review from jsonwan June 26, 2023 12:42
continue;
}

log.info("[{}]: Analyse agent task result, result: {}", gseTaskInfo, agentTaskResult);

/*为了解决shell上下文传参的问题,在下发用户脚本的时候,实际上下下发两个脚本。第一个脚本是用户脚本,第二个脚本
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释错误,多了一个“下”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@jsonwan jsonwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1处小问题

@jsonwan jsonwan merged commit b086bfb into TencentBlueKing:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants