Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: maven 配置优化 #2409 #2411

Merged
merged 2 commits into from
Aug 31, 2023
Merged

perf: maven 配置优化 #2409 #2411

merged 2 commits into from
Aug 31, 2023

Conversation

wangyu096
Copy link
Collaborator

  1. 简化 maven 配置，删除 extraMavenRepoUrl
  2. 扩展mavenRepoUrl， 支持传入多个 maven url
  3. 简化 maven repo 的配置配置，仅支持命令行指定 -DmavenRepoUrl 和 从 gradle.properties 读取，不再支持从环境变量读取（容易混乱）

@wangyu096 wangyu096 requested a review from jsonwan August 31, 2023 07:06
jsonwan
jsonwan requested changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@jsonwan jsonwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1个问题需要处理

@wangyu096 wangyu096 merged commit 3047435 into TencentBlueKing:master Aug 31, 2023
@wangyu096
Copy link
Collaborator Author

建议保留从环境变量获取的方式，防止误提交含有敏感信息的内部仓库URL

使用 gradle.properties 指定的方式更加合理，也能简化配置

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsonwan jsonwan jsonwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangyu096 @jsonwan