feat: 容器执行支持 label selector 表达式 #2858 #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wangyu096
commented
Apr 1, 2024
•
wangyu096
commented
- 实现 label selector 解析
- 修复通过分页查询方式获取容器，因为原始数据变更导致多次分页结果数据重复/遗漏的问题
jsonwan
reviewed
Apr 7, 2024
| @@ -239,6 +239,9 @@ public static <T, R> PageData<R> copyPageWithNewData(PageData<T> srcPageData, Li | |||
|
|
|||
| /** | |||
| * 查询全量 - 通过循环分页查询 | |||
| * <p> | |||
| * 注意：如果多次分页查询期间元升数据发生变化，使用该方法可能出现数据重复/遗漏的情况。该方法仅使用于对数据准确度要求不高的场景！！！ | |||
jsonwan
reviewed
Apr 7, 2024
| } catch (Throwable t) { | ||
| httpStatus = "error"; | ||
| httpStatus = HttpStatus.SC_INTERNAL_SERVER_ERROR; |
There was a problem hiding this comment.
fixed. 这个时候 http status 设置为 UNKNOWN。参考 spring actuator 的 http_server_requests 实现
jsonwan
reviewed
Apr 7, 2024
| * @param request 保存日志请求 | ||
| */ | ||
| @PostMapping("/batch") | ||
| InternalResponse<?> tmpSaveLogs( |
There was a problem hiding this comment.
这个版本就可以删除了。原始的就是 /service/log/batch, 后面不小心改成了 /batch 导致发布报错 NOT_FOUND. 后续又改回了 /service/log/batch. 引入这个方法只是为了保证 bkop 环境再次发布不会出异常的规避方案
相当于做了一次 A->B->A的修改。
jsonwan
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.