feat: 增加查询文件源与凭证详情的ApiGW接口 #2830 #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonwan
reviewed
Apr 7, 2024
| | ---------------- | ------ | ------------------------------------------------------------ | | ||
| | bk_scope_type | string | 资源范围类型。可选值: biz - 业务，biz_set - 业务集 | | ||
| | bk_scope_id | string | 资源范围ID, 与bk_scope_type对应, 表示业务ID或者业务集ID | | ||
| | id | string | 凭据ID | |
There was a problem hiding this comment.
统一使用“凭证”，与页面保持一致，其他地方也检查下，有“凭据”的地方都改过来。
jsonwan
reviewed
Apr 7, 2024
| | bk_scope_type | string | 是 | 资源范围类型。可选值: biz - 业务，biz_set - 业务集 | | ||
| | bk_scope_id | string | 是 | 资源范围ID, 与bk_scope_type对应, 表示业务ID或者业务集ID | | ||
| | bk_biz_id | long | 是 | *已弃用*。业务ID。此字段已被弃用并由字段bk_scope_type+bk_scope_id替换 | | ||
| | id | String | 是 | 凭据ID | |
There was a problem hiding this comment.
统一使用“凭证”，与页面保持一致，其他地方也检查下，有“凭据”的地方都改过来。
jsonwan
reviewed
Apr 7, 2024
|
|
||
| - GET | ||
| ```json | ||
| /api/v3/get_file_source_detail?bk_scope_type=biz&bk_scope_id=1&code=1 |
There was a problem hiding this comment.
code=1不太合适，看着像数字，可改为bkrepo-1
jsonwan
reviewed
Apr 7, 2024
| "data": { | ||
| "bk_scope_type": "biz", | ||
| "bk_scope_id": "2", | ||
| "id": 0, |
jsonwan
reviewed
Apr 7, 2024
| "code": "xxx", | ||
| "alias": "xxx", | ||
| "status": 0, | ||
| "file_source_type": 3, |
jsonwan
reviewed
Apr 7, 2024
| | code | string | 文件源code | | ||
| | alias | string | 文件源别名 | | ||
| | status | int | 状态 | | ||
| | file_source_type | int | 类型。可选值：蓝鲸制品库 | |
There was a problem hiding this comment.
这个字段建议改为文件源类型的code，类型与描述需要相应修改
jsonwan
reviewed
Apr 7, 2024
| | credential_id | string | 凭据ID | | ||
| | enable | bool | 是否启用 | | ||
| | creator | string | 作业创建人账号 | | ||
| | create_time | long | 创建时间，Unix 时间戳 | |
jsonwan
reviewed
Apr 7, 2024
| | creator | string | 作业创建人账号 | | ||
| | create_time | long | 创建时间，Unix 时间戳 | | ||
| | last_modify_user | string | 作业修改人账号 | | ||
| | last_modify_time | long | 最后修改时间，Unix 时间戳 | |
jsonwan
reviewed
Apr 7, 2024
| @@ -0,0 +1,79 @@ | |||
| ### Function Description | |||
jsonwan
reviewed
Apr 7, 2024
| @@ -291,6 +291,17 @@ | |||
| dest_http_method: POST | |||
| is_hidden: True | |||
|
|
|||
jsonwan
reviewed
Apr 7, 2024
| String username, | ||
| String appCode, | ||
| @AuditRequestBody EsbGetFileSourceDetailV3Req req) { | ||
| FileSourceDTO fileSourceDTO = fileSourceService.getFileSourceByCode(req.getCode()); |
There was a problem hiding this comment.
需要加上appId查询，code仅在appId下唯一，仅使用code获取的地方需要改过来
jsonwan
reviewed
Apr 9, 2024
| @@ -39,8 +39,9 @@ | |||
| public interface ServiceFileSourceResource { | |||
|
|
|||
| @ApiOperation(value = "获取文件源ID", produces = "application/json") | |||
| @GetMapping("/service/fileSource/getFileSourceIdByCode/codes/{code}") | |||
| @GetMapping("/service/app/{appId}/fileSource/getFileSourceIdByCode/codes/{code}") | |||
There was a problem hiding this comment.
这里不要直接改接口路径，避免发布时任务异常。
添加一个新的接口，并将老接口标记为Deprecated，在下个大版本再删除，以实现无损发布。
jsonwan
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.