feat: 执行历史归档新增模式-只备份不删除 #3037 #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wangyu096
commented
Jun 5, 2024
•
wangyu096
commented
- 该模式当前仅设计为归档功能测试&性能测试使用，保证归档测试过程中不会删除原始数据。
- 不对用户开放，文档暂时无需补充相关说明
- 优化日志
- 优化归档任务的执行结果输出详情
jsonwan
reviewed
Jun 7, 2024
| havingValue = ArchiveModeEnum.Constants.BACKUP_THEN_DELETE) | ||
| class ArchiveModeBackupThenDeleteCondition { | ||
| @Conditional(JobExecuteBackupCondition.class) | ||
| static class BackupCondition { |
There was a problem hiding this comment.
这里添加的BackupCondition看起来并没有被引用，不对任何Bean产生影响，需要确认下
There was a problem hiding this comment.
这个是 spring condition AllNestedConditional 的写法，内部定义的静态类会被作为判断条件。这个是框架使用的，业务代码本身不会处理这个逻辑。具体可以在代码中，看下 spring 框架继承 AllNestedConditions 的一些写法，跟此处类似。
该条件的生效，已经在我们内部环境在不同的归档模式 backupOnly/deleteOnly/backupThenDelete 下都有验证，符合预期。
jsonwan
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.