Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Agent / Proxy 类操作支持多接入点 Agent 操作 (closed #1714) #1791

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

wyyalt
Copy link
Collaborator

@wyyalt wyyalt commented Sep 4, 2023

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #1791 (24610f3) into v2.4.2-dev (d9ee96f) will increase coverage by 0.05%.
Report is 5 commits behind head on v2.4.2-dev.
The diff coverage is 82.81%.

@@              Coverage Diff               @@
##           v2.4.2-dev    #1791      +/-   ##
==============================================
+ Coverage       74.08%   74.13%   +0.05%     
==============================================
  Files             397      397              
  Lines           26908    27019     +111     
==============================================
+ Hits            19934    20031      +97     
- Misses           6974     6988      +14     
Files Changed Coverage Δ
apps/backend/subscription/steps/agent.py 50.00% <ø> (ø)
apps/node_man/serializers/job.py 73.31% <74.39%> (+0.26%) ⬆️
...s/backend/components/collections/agent_new/base.py 90.84% <90.90%> (-0.37%) ⬇️
...nents/collections/agent_new/check_agent_ability.py 100.00% <100.00%> (ø)
...ents/collections/agent_new/push_upgrade_package.py 100.00% <100.00%> (ø)
...nents/collections/agent_new/reload_agent_config.py 87.50% <100.00%> (+0.40%) ⬆️
...ollections/agent_new/render_and_push_gse_config.py 100.00% <100.00%> (ø)
...ackend/components/collections/agent_new/restart.py 100.00% <100.00%> (ø)
...nents/collections/agent_new/run_upgrade_command.py 97.22% <100.00%> (+0.07%) ⬆️
...nents/collections/agent_new/update_install_info.py 100.00% <100.00%> (ø)
... and 5 more

... and 8 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@wyyalt wyyalt added the pr/reviewable 可被 review 的 PR label Sep 7, 2023
agent_step_adapter: AgentStepAdapter
# 注入AP_ID
injected_ap_id: int
def get_host_ap(self, common_data: AgentCommonData, host: models.Host) -> models.AccessPoint:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 这个封装优雅

apps/backend/subscription/tools.py Outdated Show resolved Hide resolved
@wyyalt wyyalt force-pushed the _v2.4.x/dev_issue#1714 branch from 7f8281b to f14f799 Compare September 8, 2023 07:55
@wyyalt wyyalt force-pushed the _v2.4.x/dev_issue#1714 branch from f14f799 to 24610f3 Compare September 8, 2023 08:01
@wyyalt wyyalt merged commit a868481 into TencentBlueKing:v2.4.2-dev Sep 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants