refactor: npm远程仓库优化 #1168 #1173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scplsy
requested review from
felixncheng,
yaoxuwan,
cnlkl and
zacYL
as code owners
felixncheng
reviewed
Sep 19, 2023
| @@ -177,7 +175,7 @@ abstract class RemoteRepository : AbstractArtifactRepository() { | |||
| val size = artifactFile.getSize() | |||
| val artifactStream = artifactFile.getInputStream().artifactStream(Range.full(size)) | |||
| val node = cacheArtifactFile(context, artifactFile) | |||
| return ArtifactResource(artifactStream, context.artifactInfo.getResponseName(), node, ArtifactChannel.LOCAL) | |||
There was a problem hiding this comment.
这里是onDownloadResponse方法，都是远程下载的
| @@ -115,21 +115,19 @@ abstract class RemoteRepository : AbstractArtifactRepository() { | |||
| /** | |||
| * 尝试读取缓存的远程构件 | |||
| */ | |||
| fun getCacheArtifactResource(context: ArtifactDownloadContext): ArtifactResource? { | |||
| open fun getCacheArtifactResource(context: ArtifactContext): ArtifactResource? { | |||
There was a problem hiding this comment.
这里是为什么要把ArtifactDownloadContext换成ArtifactContext呢，这里应该是处理下载上下文
There was a problem hiding this comment.
查询元数据文件时使用的是ArtifactQueryContext，也会读取和缓存文件，且其它类型仓库也有类似的行为，因此扩大了这个方法的使用范围。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
描述：