feat: package自定义搜索支持版本名、元数据、checksum搜索 #1717 #1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scplsy
force-pushed
the
issue_1717
branch
2 times, most recently
from
3b07438
to
ef8e7e8
Compare
(cherry picked from commit f44cef4faca90b83052243c709d735104154de3e)
cnlkl
requested changes
Feb 1, 2024
| require(context is PackageQueryContext) | ||
| // 查找符合条件的version | ||
| val versionQuery = Query(getVersionCriteria(rule, context)) | ||
| val versionMap = queryRecords(versionQuery) { query -> packageVersionDao.find(query) } |
There was a problem hiding this comment.
- 这里没限制项目和仓库，是不是会把整个制品库所有项目符合条件的包都查出来放在内存里
- 能不能把version、metadata、checksum条件集中在一次查询中把数据都查出来
| .groupBy({ it.packageId }, { it.name }) | ||
| // 多个版本查询规则在同一个package的版本号交集 | ||
| for ((key, value) in versionMap) { | ||
| context.matchedVersions.putIfAbsent(key, value.toMutableSet())?.retainAll(value.toSet()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
描述
package自定义搜索新增以下搜索条件：
添加这些搜索条件时，搜索结果仍然为packages，但每个返回的package详情都将新增
matchedVersions数组字段，值为匹配的版本号。