Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Enhancement】完善bazel选项bazel_no_launcher的实现 #140

Closed
tming opened this issue Nov 7, 2023 · 1 comment
Closed

【Enhancement】完善bazel选项bazel_no_launcher的实现 #140

tming opened this issue Nov 7, 2023 · 1 comment
Labels
client done

Comments

@tming
Copy link
Collaborator

tming commented Nov 7, 2023

What would you like to be added:
完善bazel选项bazel_no_launcher的实现，该模式下会选第一个可用资源，但第一个资源不一定合适，需要加更多的判断

Why is this needed:
如上所示

Additional context
None
tbs60 added a commit to tbs60/bk-turbo that referenced this issue Nov 7, 2023
@tbs60
feat:more for bazel_no_launcher,issue: TencentBlueKing#140
9d742f3
tbs60 added a commit to tbs60/bk-turbo that referenced this issue Nov 7, 2023
@tbs60
feat:more for bazel_no_launcher,issue: TencentBlueKing#140
fd37f58
@tming
Copy link
Collaborator Author

tming commented Nov 8, 2023 •
edited
Loading

考虑到默认选第一个work，选错的概率比较大，增加一个约束条件：
记录初始化work的参数 --bazel_no_launcher， bazel模式下（workid为空）选择带有这个参数的work，这样在当前的环境下，出错的概率会比较小了

tbs60 added a commit to tbs60/bk-turbo that referenced this issue Nov 8, 2023
@tbs60
feat:for bazel no launcher,issue: TencentBlueKing#140
be8431c
@tming tming added done and removed todo labels May 27, 2024
@tming tming closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tming