Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue15 -- support restoration soft delete object data #70

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix issue15 -- support restoration soft delete object data #70

merged 1 commit into from
Sep 23, 2021

Conversation

uddmorningsun
Copy link
Contributor

Fix issue15: #15

Signed-off-by: Chenyang Yan memory.yancy@gmail.com

IMBlues
IMBlues reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@IMBlues IMBlues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MR 提交的好神速 🤩

src/api/bkuser_core/categories/models.py Show resolved Hide resolved
src/api/bkuser_core/common/error_codes.py Outdated Show resolved Hide resolved
src/api/bkuser_core/common/models.py Outdated Show resolved Hide resolved
src/api/bkuser_core/categories/models.py Outdated Show resolved Hide resolved
src/api/bkuser_core/common/viewset.py Outdated Show resolved Hide resolved
src/api/bkuser_core/common/viewset.py Outdated Show resolved Hide resolved
src/api/bkuser_core/profiles/models.py Outdated Show resolved Hide resolved
@uddmorningsun
Copy link
Contributor Author

已 rebased and updated，可以再次 review

IMBlues
IMBlues reviewed Sep 20, 2021
View reviewed changes
src/api/bkuser_core/categories/models.py Outdated Show resolved Hide resolved
src/api/bkuser_core/common/models.py Outdated Show resolved Hide resolved
@uddmorningsun
Fix issue15 -- support restoration soft delete object data
2367a3c 
Signed-off-by: Chenyang Yan <memory.yancy@gmail.com>
@uddmorningsun
Copy link
Contributor Author

已 rebased and updated，可以再次 review：

  • bkuser_core.categories.models.ProfileCategory.make_default_settings 已修改返回值以及 typing hints
  • bkuser_core.common.models.AdvancedModelManager.enable_or_disable 已使用 bool 类型判断，效率优先

Unittests 失败由于 poetry 依赖安装报错，hash 值不匹配，解决后并重新触发

IMBlues
IMBlues approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@IMBlues IMBlues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IMBlues IMBlues merged commit b0c926d into TencentBlueKing:development Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IMBlues IMBlues IMBlues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uddmorningsun @IMBlues